chore(common): cleanup error handling for KmxFileReader and CompilerOptions as shared type #8951
+147
−124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes handling of kmx errors in kmc-package.
Our dev env mostly assumes that build/ is for build artifacts, so this just sidesteps issues with code search, etc. The other glaring example of this is resources/build/ which is a _much_ more painful change, given how many scripts reference it. So not changing that for now.
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
github-actions
bot
added
common/
common/web/
developer/
developer/compilers/
chore
labels
This was
linked to
issues
Jun 8, 2023
Closed
Base automatically changed from
feat/typescript-keymanweb-compiler
to
feature-kmc-kmw
June 8, 2023 07:38
jahorton
approved these changes
Jun 9, 2023
Comment on lines
+69
to
+70
| newContext: -1, | ||
| postKeystroke: -1 |
There was a problem hiding this comment.
... what here got moved from "TODO" to "to-done"?
There was a problem hiding this comment.
The TODO items were done a while ago and I forgot to remove the comments when I fixed them up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8955.
Fixes #8956.
Fixes #8957.
Fixes #8958.
Also renames build/ to buildClasses/ in kmc:
Our dev env mostly assumes that build/ is for build artifacts, so this just sidesteps issues with code search, etc.
The other glaring example of this is resources/build/ which is a much more painful change, given how many scripts reference it. So not changing that for now.
Fixes restructure types per chore(common): add restructure .d.ts for esm #8945.
@keymanapp-test-bot skip